Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin workflow scripts to Ubuntu-22.04 #173

Merged
merged 4 commits into from
Dec 31, 2024
Merged

Pin workflow scripts to Ubuntu-22.04 #173

merged 4 commits into from
Dec 31, 2024

Conversation

ffoulkes
Copy link
Contributor

@ffoulkes ffoulkes commented Dec 27, 2024

  1. Changed ubuntu-latest to ubuntu-22.04 in the pipeline, in preparation for GitHub bumping ubuntu-latest to 24.04.
  2. Modified to build krnlmon in isolation, instead of building it from the networking-recipe folder.
  3. Modified to build the dummy application in addition to the library, to check for link errors.
  4. Combined the build and unit test jobs into a single build-and-test job.

The first change is in response to the following warning from GitHub Actions:

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner- 
images/issues/10636

- Changed `ubuntu-latest` to `ubuntu-22.04` in the pipeline,
  in preparation for GitHub bumping ubuntu-latest to 24.04.

Signed-off-by: Derek Foster <[email protected]>
Copy link
Collaborator

@5abeel 5abeel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Combined krnlmon build and test into a single job.

- Modified to do a standalone krnlmon build instead of building
  building from the networking-recipe folder, and to build the
  dummy executable in addition to the library.

Signed-off-by: Derek Foster <[email protected]>
@ffoulkes ffoulkes merged commit 3090e52 into main Dec 31, 2024
3 checks passed
@ffoulkes ffoulkes deleted the ubuntu-22.04 branch December 31, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants